Skip to content

Fix redis transaction registry#184

Merged
gontarzpawel merged 2 commits intomasterfrom
fix/redis-transaction-registry
Jul 7, 2022
Merged

Fix redis transaction registry#184
gontarzpawel merged 2 commits intomasterfrom
fix/redis-transaction-registry

Conversation

@gontarzpawel
Copy link
Contributor

@gontarzpawel gontarzpawel commented Jul 7, 2022

Description

Transaction registry methods: Complete and Fail, rely today on KeepTTL argument https://redis.io/commands/set/ available only from redis sever version > 6.x. The idea of this PR is to reduce dependency to specific redis version.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments


@render
Copy link

render bot commented Jul 7, 2022

@gontarzpawel gontarzpawel requested review from mga-chka and sigua-cs July 7, 2022 10:07
Copy link
Contributor

@sigua-cs sigua-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gontarzpawel gontarzpawel merged commit c63bb7c into master Jul 7, 2022
@gontarzpawel gontarzpawel deleted the fix/redis-transaction-registry branch July 7, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants